Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mpo parser #33

Closed
wants to merge 9 commits into from
Closed

Mpo parser #33

wants to merge 9 commits into from

Conversation

pnrobinson
Copy link
Collaborator

Correcting data format error as described in issue #32

holtgrewe
holtgrewe suggested changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please base diff on develop and create PR to develop. This should make changing CHANGELOG.rst, README.rst, pom.xml unnecessary.

Can you add a test for this, adding the root term of MPO with one or two child terms?

@pnrobinson
Copy link
Collaborator Author

Closing this PR and replacing by PR to develop.

@pnrobinson pnrobinson closed this Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtgrewe holtgrewe holtgrewe requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnrobinson @holtgrewe